Fix compile warnings in arm/windows #323
Conversation
Fix compiler warnings
fix compiler warning
|
Hi @davidbienvenu! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
fbarchard
left a comment
fbarchard
left a comment
There was a problem hiding this comment.
ah yes... I ran into the same issue and created a PR too.
|
@davidbienvenu Can you rebase your PR? I'll get it merged shortly. Thanks! |
|
OK, I rebased my fork. Do I need to do anything to reflect that in the PR? |
Thanks. Can you rebase the commits in the PR branch? I believe there is a button in the UI to do this, or you can rebase it via git. |
|
I rebased the commit on the PR branch, I believe |
|
@davidbienvenu Thanks. I triggered the CI run on the PR. Sorry for the back and forth, but can you resolve the clang-format complaints (see https://github.com/pytorch/cpuinfo/actions/runs/19183578467/job/54846054862?pr=323)? Everything else looks good, so I'm good to merge once that job is green. Thanks! |
attempt to fix clang format errors
attempt to fix clang format errors
|
Looks like CI is green, so I'll go ahead and merge. Thanks for your patience and for the contribution. |
|
Thanks for your patience!On Nov 7, 2025 4:47 PM, Gregory Comer ***@***.***> wrote:GregoryComer left a comment (pytorch/cpuinfo#323)
Looks like CI is green, so I'll go ahead and merge. Thanks for your patience and for the contribution.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
3 participants
This PR fixes 3 warnings when building cpuinfo for windows arm64.